danny0405 commented on code in PR #12206:
URL: https://github.com/apache/hudi/pull/12206#discussion_r1830374288
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackHelper.java:
##########
@@ -125,12 +129,17 @@ List<Pair<String, HoodieRollbackStat>>
maybeDeleteAndCollectStats(HoodieEngineCo
final StoragePath filePath;
try {
String fileId = rollbackRequest.getFileId();
+ HoodieTableVersion tableVersion =
metaClient.getTableConfig().getTableVersion();
writer = HoodieLogFormat.newWriterBuilder()
.onParentPath(FSUtils.constructAbsolutePath(metaClient.getBasePath(),
rollbackRequest.getPartitionPath()))
.withFileId(fileId)
- .withDeltaCommit(instantToRollback.getTimestamp())
+
.withLogWriteToken(CommonClientUtils.generateWriteToken(taskContextSupplier))
+
.withInstantTime(tableVersion.greaterThanOrEquals(HoodieTableVersion.EIGHT)
+ ? instantToRollback.getTimestamp() :
rollbackRequest.getLatestBaseInstant()
Review Comment:
I'm assuming this logic is copied from legacy version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
