danny0405 commented on code in PR #12206:
URL: https://github.com/apache/hudi/pull/12206#discussion_r1830375184
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/MarkerBasedRollbackStrategy.java:
##########
@@ -91,4 +101,83 @@ public List<HoodieRollbackRequest>
getRollbackRequests(HoodieInstant instantToRo
throw new HoodieRollbackException("Error rolling back using marker files
written for " + instantToRollback, e);
}
}
+
+ protected HoodieRollbackRequest createRollbackRequestForCreateMerge(String
fileId,
+ String
partitionPath,
+
StoragePath filePath,
+
HoodieInstant instantToRollback) {
+ if (table.version().greaterThanOrEquals(HoodieTableVersion.EIGHT)) {
+ return new HoodieRollbackRequest(partitionPath, fileId,
instantToRollback.getTimestamp(),
+ Collections.singletonList(filePath.toString()),
Collections.emptyMap());
+ } else {
+ String baseInstantTime = null;
+ if (FSUtils.isBaseFile(filePath)) {
+ HoodieBaseFile baseFileToDelete = new
HoodieBaseFile(filePath.toString());
+ fileId = baseFileToDelete.getFileId();
+ baseInstantTime = baseFileToDelete.getCommitTime();
Review Comment:
I'm assuming this logic is copied from legacy version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
