danny0405 commented on code in PR #11923:
URL: https://github.com/apache/hudi/pull/11923#discussion_r1830433437
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/LogCompactionExecutionHelper.java:
##########
@@ -53,7 +52,7 @@ public class LogCompactionExecutionHelper<T extends
HoodieRecordPayload, I, K, O
@Override
protected void transitionRequestedToInflight(HoodieTable table, String
logCompactionInstantTime) {
HoodieActiveTimeline timeline = table.getActiveTimeline();
- HoodieInstant instant =
HoodieTimeline.getLogCompactionRequestedInstant(logCompactionInstantTime);
+ HoodieInstant instant =
table.getMetaClient().getTimelineLayout().getInstantFactory().getLogCompactionRequestedInstant(logCompactionInstantTime);
Review Comment:
The invocation chain is way to long, maybe just
`table.getMetaClient().getInstantFactory`, let's try to limit the instant
factory instantatiation APIs to the meta client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
