danny0405 commented on code in PR #11923:
URL: https://github.com/apache/hudi/pull/11923#discussion_r1830461198
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/IncrementalRelation.scala:
##########
@@ -153,10 +153,10 @@ class IncrementalRelation(val sqlContext: SQLContext,
}.toMap
for (commit <- commitsToReturn) {
- val metadata: HoodieCommitMetadata =
HoodieCommitMetadata.fromBytes(commitTimeline.getInstantDetails(commit)
- .get, classOf[HoodieCommitMetadata])
+ val metadata: HoodieCommitMetadata =
metaClient.getTimelineLayout.getCommitMetadataSerDe.deserialize(commit,
Review Comment:
Can we limit the top-level api of `#deserialize` to either the Timeline or
the meta client, maybe just `metaClient.getInstantDeserizer.deserialize` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
