nsivabalan commented on code in PR #12236:
URL: https://github.com/apache/hudi/pull/12236#discussion_r1839063291
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -298,12 +314,56 @@ protected HoodieWriteMetadata<O> compact(String
compactionInstantTime, boolean s
table.getMetaClient().reloadActiveTimeline();
}
compactionTimer = metrics.getCompactionCtx();
+ // start commit in MDT if enabled
+ Option<HoodieTableMetadataWriter> metadataWriterOpt =
getMetadataWriterFunc.apply(compactionInstantTime, table.getMetaClient());
+ if (metadataWriterOpt.isPresent()) {
+ metadataWriterOpt.get().reInitWriteClient();
+ metadataWriterOpt.get().startCommit(compactionInstantTime);
+ }
HoodieWriteMetadata<T> writeMetadata = table.compact(context,
compactionInstantTime);
- HoodieWriteMetadata<O> compactionMetadata =
convertToOutputMetadata(writeMetadata);
- if (shouldComplete && compactionMetadata.getCommitMetadata().isPresent()) {
- completeCompaction(compactionMetadata.getCommitMetadata().get(), table,
compactionInstantTime);
+ HoodieWriteMetadata<T> processedWriteMetadata =
writeToMetadata(writeMetadata, compactionInstantTime, metadataWriterOpt);
+
+ HoodieWriteMetadata<O> compactionWriteMetadata =
convertToOutputMetadata(processedWriteMetadata);
+ if (shouldComplete) {
+ // don't need to support auto commit flow.
+ // triggering dag for compaction here.
+ commitCompaction(compactionInstantTime, compactionWriteMetadata,
Option.of(table), metadataWriterOpt);
}
- return compactionMetadata;
+ return compactionWriteMetadata;
+ }
+
+ protected HoodieWriteMetadata<T> writeToMetadata(HoodieWriteMetadata<T>
writeMetadata, String compactionInstantTime,
+
Option<HoodieTableMetadataWriter> metadataWriterOpt) {
+ return writeMetadata;
+ }
+
+ protected abstract Pair<List<HoodieWriteStat>, List<HoodieWriteStat>>
processAndFetchHoodieWriteStats(HoodieWriteMetadata<O> writeMetadata);
+
+ public void commitCompaction(String compactionInstantTime,
HoodieWriteMetadata<O> compactionWriteMetadata, Option<HoodieTable> tableOpt,
+ Option<HoodieTableMetadataWriter>
metadataWriterOpt) {
+ // dereferencing the write dag for compaction for the first time.
+ Pair<List<HoodieWriteStat>, List<HoodieWriteStat>>
dataTableAndMetadataTableHoodieWriteStats =
processAndFetchHoodieWriteStats(compactionWriteMetadata);
+ HoodieCommitMetadata commitMetadata = new HoodieCommitMetadata(true);
Review Comment:
here is where the commit metadata is prepared for Compaction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
