danny0405 commented on code in PR #11923:
URL: https://github.com/apache/hudi/pull/11923#discussion_r1839316525
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/CompactionCommand.java:
##########
@@ -381,20 +382,21 @@ private HoodieCompactionPlan
readCompactionPlanForArchivedTimeline(HoodieArchive
*/
private HoodieCompactionPlan
readCompactionPlanForActiveTimeline(HoodieActiveTimeline activeTimeline,
HoodieInstant instant) {
+ InstantGenerator instantFactory =
HoodieCLI.getTableMetaClient().getInstantGenerator();
Review Comment:
I see many places where the class name is renamed to `xxxGenerator` but the
variable name is still `xxxFactory`, can we fix that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
