danny0405 commented on code in PR #11923:
URL: https://github.com/apache/hudi/pull/11923#discussion_r1839408851
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/CompactionCommand.java:
##########
@@ -246,7 +247,7 @@ public String compact(
Option<String> firstPendingInstant =
client.reloadActiveTimeline().filterCompletedAndCompactionInstants()
.filter(instant ->
instant.getAction().equals(HoodieTimeline.COMPACTION_ACTION)).firstInstant()
- .map(HoodieInstant::getTimestamp);
+ .map(HoodieInstant::requestedTime);
Review Comment:
Forget it, I thought it again and `requestTime` does not really conflict
with incremental query `startTime`, the former is for instant request
time(start time), the later is for query range start time(which is actually a
completion time).
They are two kind of things technically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
