vinothchandar commented on code in PR #12266:
URL: https://github.com/apache/hudi/pull/12266#discussion_r1844994642
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1031,6 +1031,7 @@ public void dropIndex(List<String> metadataPartitions) {
if (metadataWriterOpt.isPresent()) {
try (HoodieTableMetadataWriter metadataWriter =
metadataWriterOpt.get()) {
metadataWriter.dropMetadataPartitions(metadataPartitions);
+ metadataPartitions.forEach(partition ->
table.getMetaClient().deleteIndexDefinition(partition));
Review Comment:
what happens if we fail after L1033.. and re try.. would it still work
correctly/idempotent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
