lokeshj1703 commented on code in PR #12266:
URL: https://github.com/apache/hudi/pull/12266#discussion_r1845465839


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1031,6 +1031,7 @@ public void dropIndex(List<String> metadataPartitions) {
       if (metadataWriterOpt.isPresent()) {
         try (HoodieTableMetadataWriter metadataWriter = 
metadataWriterOpt.get()) {
           metadataWriter.dropMetadataPartitions(metadataPartitions);
+          metadataPartitions.forEach(partition -> 
table.getMetaClient().deleteIndexDefinition(partition));

Review Comment:
   Made a change to make sure the metadata changes are made before data 
deletion. By design the metadata partitions in table config were updated before 
partition deletion to handle the case of partial partition deletion. Following 
the same logic here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to