danny0405 commented on code in PR #12269:
URL: https://github.com/apache/hudi/pull/12269#discussion_r1847724782
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java:
##########
@@ -659,6 +659,10 @@ private void processDataBlock(HoodieDataBlock dataBlock,
Option<KeySpec> keySpec
*/
protected abstract void processNextDeletedRecord(DeleteRecord deleteRecord);
+ public Set<String> getDeletedRecordKeys() {
+ throw new HoodieException("Inherited class needs to override to provide a
concrete implementation");
+ }
Review Comment:
I would say we add a specific delete records callback just in
`HoodieUnMergedLogRecordScanner` to collect the deleted keys, so that we can
avoid the changes for this base class and also the member variable in
`HoodieUnMergedLogRecordScanner`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
