danny0405 commented on code in PR #12297:
URL: https://github.com/apache/hudi/pull/12297#discussion_r1849492126
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java:
##########
@@ -445,7 +444,7 @@ public Builder withOptimizedLogBlocksScan(boolean
enableOptimizedLogBlocksScan)
@Override
public Builder withRecordMerger(HoodieRecordMerger recordMerger) {
- this.recordMerger =
HoodieRecordUtils.mergerToPreCombineMode(recordMerger);
+ this.recordMerger = recordMerger;
Review Comment:
The `#preCombine` is invoked for log records merging in the very first place
for early releases, let's figure out why the compaction got issues, at least
the `#preCombine` also choose records based on `orderingVal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
