danny0405 commented on code in PR #12297:
URL: https://github.com/apache/hudi/pull/12297#discussion_r1851198002


##########
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java:
##########
@@ -48,16 +48,7 @@ public OverwriteWithLatestAvroPayload(Option<GenericRecord> 
record) {
 
   @Override
   public OverwriteWithLatestAvroPayload 
preCombine(OverwriteWithLatestAvroPayload oldValue) {
-    if (oldValue.recordBytes.length == 0) {
-      // use natural order for delete record

Review Comment:
   Instead of modifying the existing payload, can we write a new payload named 
`CommitTimeAvroPayload` akka to the renamed merger mode: `COMMIT_TIME_ORDERING`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to