yihua commented on code in PR #12283:
URL: https://github.com/apache/hudi/pull/12283#discussion_r1849620776
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableInsertUpdateDelete.java:
##########
@@ -264,11 +263,11 @@ public void testRepeatedRollbackOfCompaction() throws
Exception {
}
}
- @Disabled("HUDI-8203")
@ParameterizedTest
@ValueSource(booleans = {true, false})
public void testSimpleInsertUpdateAndDelete(boolean populateMetaFields)
throws Exception {
Properties properties = populateMetaFields ? new Properties() :
getPropertiesForKeyGen();
+ properties.setProperty(HoodieTableConfig.PRECOMBINE_FIELD.key(),
"timestamp");
Review Comment:
Does this mean that without preCombine field it does not work? I've marked
this test to be revisited by
[HUDI-8551](https://issues.apache.org/jira/browse/HUDI-8551).
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HiveHoodieReaderContext.java:
##########
@@ -265,10 +266,10 @@ public UnaryOperator<ArrayWritable> projectRecord(Schema
from, Schema to, Map<St
@Override
public Comparable castValue(Comparable value, Schema.Type newType) {
//TODO: [HUDI-8261] actually do casting here
- if (newType == Schema.Type.STRING) {
- return value.toString();
+ if (value instanceof WritableComparable) {
+ return value;
}
- return value;
+ return (WritableComparable)
HoodieRealtimeRecordReaderUtils.avroToArrayWritable(value,
Schema.create(newType));
Review Comment:
Is this all we need for fixing HUDI-8261 too? If so, could we make
HUDI-8261 fix version 1.0.0 and mark it as closed after this PR is merged? And
remove `//TODO: [HUDI-8261] actually do casting here`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
