yihua commented on code in PR #12283:
URL: https://github.com/apache/hudi/pull/12283#discussion_r1854612455
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableInsertUpdateDelete.java:
##########
@@ -264,11 +263,11 @@ public void testRepeatedRollbackOfCompaction() throws
Exception {
}
}
- @Disabled("HUDI-8203")
@ParameterizedTest
@ValueSource(booleans = {true, false})
public void testSimpleInsertUpdateAndDelete(boolean populateMetaFields)
throws Exception {
Properties properties = populateMetaFields ? new Properties() :
getPropertiesForKeyGen();
+ properties.setProperty(HoodieTableConfig.PRECOMBINE_FIELD.key(),
"timestamp");
Review Comment:
We should get rid of the casting logic and do not allow preCombine field
type to change. And treat `(int) 0` as natural ordering, i.e., `(int) 0`
should not be compared with real ordering value, and `(int) 0` marks commit
time ordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
