lokeshj1703 commented on code in PR #12266:
URL: https://github.com/apache/hudi/pull/12266#discussion_r1850648618
##########
hudi-common/src/main/java/org/apache/hudi/metadata/MetadataPartitionType.java:
##########
@@ -312,6 +312,11 @@ private static void
constructColumnStatsMetadataPayload(HoodieMetadataPayload pa
}
}
+ public static boolean isGenericIndex(String metadataPartitionPath) {
Review Comment:
Addressed
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/HoodieSparkIndexClient.java:
##########
@@ -82,8 +82,10 @@ public static HoodieSparkIndexClient
getInstance(SparkSession sparkSession) {
@Override
public void create(HoodieTableMetaClient metaClient, String indexName,
String indexType, Map<String, Map<String, String>> columns, Map<String, String>
options) {
- indexName = indexType.equals(PARTITION_NAME_SECONDARY_INDEX) ?
PARTITION_NAME_SECONDARY_INDEX_PREFIX + indexName :
PARTITION_NAME_FUNCTIONAL_INDEX_PREFIX + indexName;
- if (indexExists(metaClient, indexName)) {
+ String hoodieIndexName = indexType.equals(PARTITION_NAME_SECONDARY_INDEX)
Review Comment:
I wanted to differentiate between user provided index name and internal
index name. Made a change to have userIndexName and fullIndexName
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
