codope commented on code in PR #12288:
URL: https://github.com/apache/hudi/pull/12288#discussion_r1851403041
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v2/ActiveTimelineV2.java:
##########
@@ -723,9 +728,9 @@ public void saveToPendingIndexAction(HoodieInstant instant,
Option<byte[]> conte
protected void createFileInMetaPath(String filename, Option<byte[]> content,
boolean allowOverwrite) {
StoragePath fullPath = getInstantFileNamePath(filename);
if (allowOverwrite ||
metaClient.getTimelineLayoutVersion().isNullVersion()) {
- FileIOUtils.createFileInPath(metaClient.getStorage(), fullPath, content);
+ FileIOUtils.createFileInPath(metaClient.getStorage(timelinePath),
fullPath, content);
} else {
- metaClient.getStorage().createImmutableFileInPath(fullPath, content);
+ metaClient.getStorage(timelinePath).createImmutableFileInPath(fullPath,
content);
Review Comment:
Don't we need this change in `ActiveTimelineV1.createFileInMetaPath`?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -393,11 +400,15 @@ public Boolean isMetadataTable() {
public HoodieStorage getStorage() {
if (storage == null) {
- storage = getStorage(metaPath, getStorageConf(), consistencyGuardConfig,
fileSystemRetryConfig);
+ storage = getStorage(metaPath);
}
return storage;
}
+ public HoodieStorage getStorage(StoragePath storagePath) {
+ return getStorage(metaPath, getStorageConf(), consistencyGuardConfig,
fileSystemRetryConfig);
Review Comment:
Should we pass `storagePath` instead of `metaPath` to `getStorage`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
