jonvex commented on code in PR #12287: URL: https://github.com/apache/hudi/pull/12287#discussion_r1854210237
########## packaging/bundle-validation/validate.sh: ########## @@ -280,18 +280,12 @@ if [ "$?" -ne 0 ]; then fi echo "::warning::validate.sh done validating spark & hadoop-mr bundle" -#TODO [HUDI-8295] get this working for some of the supported spark versions -if [[ $SPARK_HOME == *"spark-2.4"* ]] || [[ $SPARK_HOME == *"spark-3.1"* ]] -then - echo "::warning::validate.sh validating utilities bundle" - test_utilities_bundle $JARS_DIR/utilities.jar - if [ "$?" -ne 0 ]; then - exit 1 - fi - echo "::warning::validate.sh done validating utilities bundle" -else - echo "::warning::validate.sh skip validating utilities bundle for non-spark2.4 & non-spark3.1 build" +echo "::warning::validate.sh validating utilities bundle" +test_utilities_bundle $JARS_DIR/utilities.jar Review Comment: It doesn't actually have anything to do with spark 3.1. I think we just wanted to test 1 spark2 version and 1 spark 3 version. But since we only have 3 spark versions supported currently I think it's fine to test all of them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
