nsivabalan commented on code in PR #12287: URL: https://github.com/apache/hudi/pull/12287#discussion_r1855251763
########## packaging/bundle-validation/validate.sh: ########## @@ -280,18 +280,12 @@ if [ "$?" -ne 0 ]; then fi echo "::warning::validate.sh done validating spark & hadoop-mr bundle" -#TODO [HUDI-8295] get this working for some of the supported spark versions -if [[ $SPARK_HOME == *"spark-2.4"* ]] || [[ $SPARK_HOME == *"spark-3.1"* ]] -then - echo "::warning::validate.sh validating utilities bundle" - test_utilities_bundle $JARS_DIR/utilities.jar - if [ "$?" -ne 0 ]; then - exit 1 - fi - echo "::warning::validate.sh done validating utilities bundle" -else - echo "::warning::validate.sh skip validating utilities bundle for non-spark2.4 & non-spark3.1 build" +echo "::warning::validate.sh validating utilities bundle" +test_utilities_bundle $JARS_DIR/utilities.jar Review Comment: nope. we generate the fat utilities bundle only for 1 version of spark2 and 1 version of spark3. for eg, we have 3 spark bundles for spark pertaining to spark3.1, spark3.2, spark3.4 and spark3.5 but for utilities, we only have 1 bundle. for diff combinations of spark versions, we recommend users to go w/ utilities slim bundle + the resp spark bundle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
