prashantwason commented on a change in pull request #2064:
URL: https://github.com/apache/hudi/pull/2064#discussion_r491341159
##########
File path: hudi-client/src/main/java/org/apache/hudi/table/HoodieTable.java
##########
@@ -253,6 +254,15 @@ public SyncableFileSystemView getHoodieView() {
return getViewManager().getFileSystemView(metaClient);
}
+ private SyncableFileSystemView getFileSystemViewInternal(HoodieTimeline
timeline) {
+ if (config.useFileListingMetadata()) {
+ FileSystemViewStorageConfig viewConfig = config.getViewStorageConfig();
+ return new HoodieMetadataFileSystemView(metaClient, timeline,
viewConfig.isIncrementalTimelineSyncEnabled());
+ } else {
+ return getViewManager().getFileSystemView(metaClient);
Review comment:
Not currently as entire metadata code is within hudi-client and
viewManager is within hudi-common.
I will have to eventually restructure into metadata-reader and
metadata-writer and I will make this change then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
