vinothchandar commented on a change in pull request #2064: URL: https://github.com/apache/hudi/pull/2064#discussion_r492405639
########## File path: hudi-client/src/main/java/org/apache/hudi/metadata/HoodieMetadata.java ########## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.metadata; + +import java.io.IOException; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileStatus; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hudi.avro.model.HoodieCleanerPlan; +import org.apache.hudi.avro.model.HoodieRestoreMetadata; +import org.apache.hudi.avro.model.HoodieRollbackMetadata; +import org.apache.hudi.common.fs.FSUtils; +import org.apache.hudi.common.model.HoodieCommitMetadata; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.exception.HoodieMetadataException; +import org.apache.hudi.exception.TableNotFoundException; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; +import org.apache.spark.api.java.JavaSparkContext; + +/** + * Defines the interface through which file listing metadata is created, updated and accessed. This metadata is + * saved within an internal Metadata Table. + * + * If file listing metadata is disabled, the functions default to using listStatus(...) RPC calls to retrieve + * file listings from the file system. + */ +public class HoodieMetadata { + private static final Logger LOG = LogManager.getLogger(HoodieMetadata.class); + + // Instances of metadata for each basePath + private static Map<String, HoodieMetadataImpl> instances = new HashMap<>(); Review comment: I don't know if sharing this object leads to any real perf gains. for the use-case you mention, those are two different hudi tables anyway right. yes, we need to pass this around the layers. best way is to stick this into `HoodieTable` just like it has a member variable for `index`. Then you can easily access this across layers. This also has to be made `Serializable`. In general, global static objects, when clearly there is a scope for separating the instances is kind of an anti pattern in Java land. Its okay if you want to defer this to me. Just saying that we will probably have to change this code eventually for these reasons. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
