yanghua commented on a change in pull request #2093:
URL: https://github.com/apache/hudi/pull/2093#discussion_r491353933
##########
File path:
hudi-spark/src/main/java/org/apache/hudi/keygen/CustomKeyGenerator.java
##########
@@ -58,6 +59,7 @@
public CustomKeyGenerator(TypedProperties props) {
super(props);
+ this.props = props;
Review comment:
Hey, Since there is a protected `config` field in `KeyGenerator`, which
can be shared with all subclasses. Why do not we check that must be
non-nullable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
