vinothchandar commented on a change in pull request #2093:
URL: https://github.com/apache/hudi/pull/2093#discussion_r492941322
##########
File path:
hudi-spark/src/main/java/org/apache/hudi/keygen/CustomKeyGenerator.java
##########
@@ -58,6 +59,7 @@
public CustomKeyGenerator(TypedProperties props) {
super(props);
+ this.props = props;
Review comment:
+1 there is no need to duplicate this again in the sub class right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]