danny0405 commented on code in PR #12327:
URL: https://github.com/apache/hudi/pull/12327#discussion_r1855713869
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##########
@@ -153,6 +153,21 @@ public int archiveIfRequired(HoodieEngineContext context,
boolean acquireLock) t
txnManager.beginTransaction(Option.empty(), Option.empty());
}
List<HoodieInstant> instantsToArchive =
getInstantsToArchive().collect(Collectors.toList());
+ return archiveInstants(context, instantsToArchive, false);
Review Comment:
I have similiar concerns, the multiple-level falgs for lock control is
error-prone, we should avoid that as much as possible, and we we need a lock
for upgrade/downgrade then, I don't think there is concurrency here.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##########
@@ -153,6 +153,21 @@ public int archiveIfRequired(HoodieEngineContext context,
boolean acquireLock) t
txnManager.beginTransaction(Option.empty(), Option.empty());
}
List<HoodieInstant> instantsToArchive =
getInstantsToArchive().collect(Collectors.toList());
+ return archiveInstants(context, instantsToArchive, false);
Review Comment:
I have similiar concerns, the multiple-level falgs for lock control is
error-prone, we should avoid that as much as possible, and why we need a lock
for upgrade/downgrade then, I don't think there is concurrency here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
