danny0405 commented on code in PR #12327:
URL: https://github.com/apache/hudi/pull/12327#discussion_r1855715788
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/EightToSevenDowngradeHandler.java:
##########
@@ -79,10 +79,13 @@ public class EightToSevenDowngradeHandler implements
DowngradeHandler {
public Map<ConfigProperty, String> downgrade(HoodieWriteConfig config,
HoodieEngineContext context, String instantTime, SupportsUpgradeDowngrade
upgradeDowngradeHelper) {
final HoodieTable table = upgradeDowngradeHelper.getTable(config, context);
Map<ConfigProperty, String> tablePropsToAdd = new HashMap<>();
- UpgradeDowngradeUtils.runCompaction(table, context, config,
upgradeDowngradeHelper);
- UpgradeDowngradeUtils.syncCompactionRequestedFileToAuxiliaryFolder(table);
+ // Rollback and run compaction in one step
Review Comment:
should be good because we fix the read for 1.x log reader from 0.x table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
