danny0405 commented on code in PR #12297:
URL: https://github.com/apache/hudi/pull/12297#discussion_r1856456009
##########
hudi-common/src/main/java/org/apache/hudi/common/model/AWSDmsAvroPayload.java:
##########
@@ -68,6 +68,20 @@ private Option<IndexedRecord>
handleDeleteOperation(IndexedRecord insertValue) t
return delete ? Option.empty() : Option.of(insertValue);
}
+ @Override
+ public OverwriteWithLatestAvroPayload
preCombine(OverwriteWithLatestAvroPayload oldValue) {
Review Comment:
I mean we need a base class for the shared `#preCombine` logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
