yihua commented on code in PR #12297:
URL: https://github.com/apache/hudi/pull/12297#discussion_r1857277750
##########
hudi-common/src/main/java/org/apache/hudi/common/model/AWSDmsAvroPayload.java:
##########
@@ -68,6 +68,20 @@ private Option<IndexedRecord>
handleDeleteOperation(IndexedRecord insertValue) t
return delete ? Option.empty() : Option.of(insertValue);
}
+ @Override
+ public OverwriteWithLatestAvroPayload
preCombine(OverwriteWithLatestAvroPayload oldValue) {
Review Comment:
As a minimal fix and backwards compatibility, it's OK to fix the
`#preCombine` implementation directly of all payload classes extending
`OverwriteWithLatestAvroPayload` which are supposed to use ordering value in
the preCombine, so the `#preCombine` logic is clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
