nsivabalan commented on code in PR #12369:
URL: https://github.com/apache/hudi/pull/12369#discussion_r1862763143
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/index/IndexingCatchupTaskFactory.java:
##########
@@ -36,11 +38,14 @@ public static IndexingCatchupTask
createCatchupTask(List<HoodieIndexPartitionInf
HoodieTableMetadataWriter metadataWriter,
List<HoodieInstant>
instantsToIndex,
Set<String>
metadataCompletedInstants,
- HoodieTableMetaClient
metaClient,
+ HoodieTable table,
HoodieTableMetaClient
metadataMetaClient,
String
currentCaughtupInstant,
TransactionManager
transactionManager,
HoodieEngineContext
engineContext) {
+ HoodieTableMetaClient metaClient = table.getMetaClient();
+ HoodieHeartbeatClient heartbeatClient = new
HoodieHeartbeatClient(table.getStorage(), metaClient.getBasePath().toString(),
table.getConfig().getHoodieClientHeartbeatIntervalInMs(),
Review Comment:
should we create the heartbeat in the constructor of RunIndexActionExecutor.
which is where transaction manager is created and passed along
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/index/AbstractIndexingCatchupTask.java:
##########
@@ -155,6 +164,15 @@ HoodieInstant awaitInstantCaughtUp(HoodieInstant instant) {
return null;
}
if (!instant.isCompleted()) {
+ // check if instant heartbeat expired, if so then ignore this instant
+ try {
+ if (table.getConfig().getFailedWritesCleanPolicy().isLazy() &&
heartbeatClient.isHeartbeatExpired(instant.requestedTime())) {
+ LOG.info("Ignoring instant " + instant + " as heartbeat expired");
+ return null;
Review Comment:
and yes. same comment as vc.
awaitInstantCaughtUp(HoodieInstant instant) does not change the instant
anyways. So, why not return boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
