codope commented on code in PR #12369:
URL: https://github.com/apache/hudi/pull/12369#discussion_r1863519008
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/index/AbstractIndexingCatchupTask.java:
##########
@@ -155,6 +164,15 @@ HoodieInstant awaitInstantCaughtUp(HoodieInstant instant) {
return null;
}
if (!instant.isCompleted()) {
+ // check if instant heartbeat expired, if so then ignore this instant
+ try {
+ if (table.getConfig().getFailedWritesCleanPolicy().isLazy() &&
heartbeatClient.isHeartbeatExpired(instant.requestedTime())) {
+ LOG.info("Ignoring instant " + instant + " as heartbeat expired");
+ return null;
Review Comment:
I can't recall why it was this way but no use, so now i have changed it to
boolean and heartbeat check is as follows:
1. If no heart beat, then ignore and just move on.
2. If heart beat exists, but expire, then also ignore and move on. If not
expired then wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
