danny0405 commented on code in PR #12390:
URL: https://github.com/apache/hudi/pull/12390#discussion_r1865565357


##########
hudi-common/src/main/java/org/apache/hudi/common/engine/TaskContextSupplier.java:
##########
@@ -35,4 +36,8 @@ public abstract class TaskContextSupplier implements 
Serializable {
   public abstract Supplier<Long> getAttemptIdSupplier();
 
   public abstract Option<String> getProperty(EngineProperty prop);
+
+  public Option<HoodieReaderContext> getReaderContext(HoodieTableMetaClient 
metaClient, boolean useReaderContext) {

Review Comment:
   There is no usage for this method, and I don't think the task comtext 
supplier is the role to hold the reader context.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to