yihua commented on code in PR #12390:
URL: https://github.com/apache/hudi/pull/12390#discussion_r1866856943
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/HoodieCompactor.java:
##########
@@ -160,67 +180,100 @@ public List<WriteStatus> compact(HoodieCompactionHandler
compactionHandler,
String maxInstantTime,
Option<InstantRange> instantRange,
TaskContextSupplier taskContextSupplier,
- CompactionExecutionHelper executionHelper)
throws IOException {
- HoodieStorage storage = metaClient.getStorage();
- Schema readerSchema;
- Option<InternalSchema> internalSchemaOption = Option.empty();
- if (!StringUtils.isNullOrEmpty(config.getInternalSchema())) {
- readerSchema = new Schema.Parser().parse(config.getSchema());
- internalSchemaOption = SerDeHelper.fromJson(config.getInternalSchema());
- // its safe to modify config here, since we are running in task side.
- ((HoodieTable) compactionHandler).getConfig().setDefault(config);
+ CompactionExecutionHelper executionHelper,
+ boolean useFileGroupReaderBasedCompaction,
+ Option<CompactorBroadcastManager>
broadcastManagerOpt) throws IOException {
+ if (useFileGroupReaderBasedCompaction) {
Review Comment:
This is done. Good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
