yihua commented on code in PR #12390:
URL: https://github.com/apache/hudi/pull/12390#discussion_r1866874625
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkTaskContextSupplier.java:
##########
@@ -90,4 +121,18 @@ public Option<String> getProperty(EngineProperty prop) {
throw new HoodieException("Unknown engine property :" + prop);
}
+ @Override
+ public Option<HoodieReaderContext> getReaderContext(HoodieTableMetaClient
metaClient, boolean useReaderContext) {
Review Comment:
Right now the `HoodieReaderContext` is designed to be engine-specific.
Ideally it should be in `HoodieEngineContext`. We've created
`EngineBroadcastManager` to retrieve the reader context. HUDI-8637 as the
follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
