geserdugarov commented on code in PR #12516:
URL: https://github.com/apache/hudi/pull/12516#discussion_r1891068828


##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataCreateHandle.java:
##########
@@ -90,6 +91,7 @@ public HoodieRowDataCreateHandle(HoodieTable table, 
HoodieWriteConfig writeConfi
     this.fileId = fileId;
     this.newRecordLocation = new HoodieRecordLocation(instantTime, fileId);
     this.preserveHoodieMetadata = preserveHoodieMetadata;
+    this.skipMetadataWrite = skipMetadataWrite;

Review Comment:
   Yes, I saw https://github.com/apache/hudi/pull/12404 and was confused by 
ticket name, which mention Flink table config `hoodie.populate.meta.fields`, 
and didn't find any changes in `hudi-flink-client` or `hudi-flink-datasource` 
that will change current behavior. My point of view I described in 
https://github.com/apache/hudi/pull/12404#issuecomment-2550559944
   And to support my comment, I created this MR that shows the lack of support 
of hoodie.populate.meta.fields` in Flink.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to