danny0405 commented on code in PR #12516:
URL: https://github.com/apache/hudi/pull/12516#discussion_r1891140388
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataCreateHandle.java:
##########
@@ -90,6 +91,7 @@ public HoodieRowDataCreateHandle(HoodieTable table,
HoodieWriteConfig writeConfi
this.fileId = fileId;
this.newRecordLocation = new HoodieRecordLocation(instantTime, fileId);
this.preserveHoodieMetadata = preserveHoodieMetadata;
+ this.skipMetadataWrite = skipMetadataWrite;
Review Comment:
It looks like the flag `preserveHoodieMetadata` indicates whether the source
row includes the metadata fields already, for table service like clustering,
this should be true by default(because clustering is just a rewrite). For
regular write, the metadata fields should be generated on the fly.
Let's check in which case the option `hoodie.populate.meta.fields` could be
false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
