zhangyue19921010 commented on code in PR #12601:
URL: https://github.com/apache/hudi/pull/12601#discussion_r1915929252
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/strategy/PartitionAwareClusteringPlanStrategy.java:
##########
@@ -55,7 +59,7 @@ public PartitionAwareClusteringPlanStrategy(HoodieTable
table, HoodieEngineConte
/**
* Create Clustering group based on files eligible for clustering in the
partition.
*/
- protected Stream<HoodieClusteringGroup>
buildClusteringGroupsForPartition(String partitionPath, List<FileSlice>
fileSlices) {
+ protected Pair<Stream<HoodieClusteringGroup>, Boolean>
buildClusteringGroupsForPartition(String partitionPath, List<FileSlice>
fileSlices) {
Review Comment:
added.
```
/**
* Create Clustering group based on files eligible for clustering in the
partition.
* return stream of HoodieClusteringGroup and boolean partial Scheduled
indicating whether all given fileSlices in the current partition have been
processed.
* For example, if some file slices will not be processed due to
writeConfig.getClusteringMaxNumGroups(), then return false
*/
```
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/strategy/PartitionAwareClusteringPlanStrategy.java:
##########
@@ -68,6 +72,7 @@ protected Stream<HoodieClusteringGroup>
buildClusteringGroupsForPartition(String
- (o1.getBaseFile().isPresent() ?
o1.getBaseFile().get().getFileSize() : writeConfig.getParquetMaxFileSize())));
long totalSizeSoFar = 0;
+ boolean isAllSlicesIncluded = true;
Review Comment:
changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
