zhangyue19921010 commented on code in PR #12601:
URL: https://github.com/apache/hudi/pull/12601#discussion_r1915929990
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/plan/generators/BaseHoodieCompactionPlanGenerator.java:
##########
@@ -182,12 +186,14 @@ public HoodieCompactionPlan generateCompactionPlan(String
compactionInstant) thr
return compactionPlan;
}
- protected abstract HoodieCompactionPlan
getCompactionPlan(HoodieTableMetaClient metaClient,
List<HoodieCompactionOperation> operations);
+ protected abstract List<String> getPartitions();
+
+ protected abstract HoodieCompactionPlan
getCompactionPlan(HoodieTableMetaClient metaClient,
List<HoodieCompactionOperation> operations, Pair<List<String>,List<String>>
partitionPair);
Review Comment:
because we need to record this missing
partitions(`.setMissingSchedulePartitions(res)`) in plan during
`getCompactionPlan function`
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/strategy/BoundedIOCompactionStrategy.java:
##########
@@ -46,7 +47,7 @@ public List<HoodieCompactionOperation>
orderAndFilter(HoodieWriteConfig writeCon
targetIORemaining -= opIo;
finalOperations.add(op);
if (targetIORemaining <= 0) {
- return finalOperations;
+ missingPartitions.add(op.getPartitionPath());
Review Comment:
changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
