danny0405 commented on code in PR #12601:
URL: https://github.com/apache/hudi/pull/12601#discussion_r1915983411


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/strategy/BoundedIOCompactionStrategy.java:
##########
@@ -46,7 +47,7 @@ public List<HoodieCompactionOperation> 
orderAndFilter(HoodieWriteConfig writeCon
       targetIORemaining -= opIo;
       finalOperations.add(op);
       if (targetIORemaining <= 0) {
-        return finalOperations;
+        missingPartitions.add(op.getPartitionPath());

Review Comment:
   Can we add some doc around the return values of `#orderAndFilter`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to