codope commented on code in PR #12638:
URL: https://github.com/apache/hudi/pull/12638#discussion_r1917847201
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -378,7 +378,8 @@ public static boolean metadataPartitionExists(StoragePath
basePath, HoodieEngine
public static Map<String, HoodieData<HoodieRecord>>
convertMetadataToRecords(HoodieEngineContext context, HoodieConfig
hoodieConfig, HoodieCommitMetadata commitMetadata,
String instantTime, HoodieTableMetaClient dataMetaClient, HoodieTableMetadata
tableMetadata,
HoodieMetadataConfig metadataConfig, List<MetadataPartitionType>
enabledPartitionTypes, String bloomFilterType,
-
int bloomIndexParallelism, Integer writesFileIdEncoding, EngineType engineType)
{
+
int bloomIndexParallelism, Integer writesFileIdEncoding, EngineType engineType,
Review Comment:
unrelated to the patch - can we keep `writesFileIdEncoding` as primitive
`int` instead of `Integer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
