danny0405 commented on code in PR #12601:
URL: https://github.com/apache/hudi/pull/12601#discussion_r1920932312


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseTableServicePlanActionExecutor.java:
##########
@@ -116,7 +116,7 @@ public Pair<Option<HoodieInstant>, Set<String>> 
getIncrementalPartitions(TableSe
     String rightBoundary = instantTime;
     // compute [leftBoundary, rightBoundary) as time window
     HoodieActiveTimeline activeTimeline = table.getActiveTimeline();
-    Set<String> partitionsInCommitMeta = 
table.getActiveTimeline().filterCompletedInstants().getCommitsTimeline().getInstantsAsStream()
+    Set<String> partitionsInCommitMeta = 
table.getActiveTimeline().findInstantsAfter(leftBoundary).filterCompletedInstants().getCommitsTimeline().getInstantsAsStream()

Review Comment:
   why filtering the instant time by `leftBoundary`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to