zhangyue19921010 commented on code in PR #12601:
URL: https://github.com/apache/hudi/pull/12601#discussion_r1921747178
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseTableServicePlanActionExecutor.java:
##########
@@ -116,7 +116,7 @@ public Pair<Option<HoodieInstant>, Set<String>>
getIncrementalPartitions(TableSe
String rightBoundary = instantTime;
// compute [leftBoundary, rightBoundary) as time window
HoodieActiveTimeline activeTimeline = table.getActiveTimeline();
- Set<String> partitionsInCommitMeta =
table.getActiveTimeline().filterCompletedInstants().getCommitsTimeline().getInstantsAsStream()
+ Set<String> partitionsInCommitMeta =
table.getActiveTimeline().findInstantsAfter(leftBoundary).filterCompletedInstants().getCommitsTimeline().getInstantsAsStream()
Review Comment:
@danny0405 Nice catch Danny.
At first I just wanted to filter out the left boundary instant itself, but
obviously I called the API `findInstantsAfter` by mistake. Here we should get
and filter the entire active time line complete instants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
