vamshipasunuru commented on PR #12608: URL: https://github.com/apache/hudi/pull/12608#issuecomment-2603829356
Yes can be removed, theres a post processing that drains the queue, will fix. On Mon, Jan 20, 2025 at 8:06 PM Danny Chan ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/FormatUtils.java > <https://github.com/apache/hudi/pull/12608#discussion_r1923042385>: > > > @@ -181,9 +172,6 @@ public static HoodieMergedLogRecordScanner logScanner( > * Utility to read and buffer the records in the unMerged log record scanner. > */ > public static class BoundedMemoryRecords { > - // Executor that runs the above producers in parallel > > BoundedMemoryRecords can be eliminated too I guess. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/hudi/pull/12608#pullrequestreview-2563433279>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/A6NDCQI5UHSGFKFYZWFAKYT2LXBU7AVCNFSM6AAAAABU4DKOA2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRTGQZTGMRXHE> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
