vamshipasunuru commented on code in PR #12608:
URL: https://github.com/apache/hudi/pull/12608#discussion_r1940541684
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java:
##########
@@ -372,7 +372,7 @@ private void scanInternalV1(Option<KeySpec> keySpecOpt) {
}
}
// merge the last read block when all the blocks are done reading
- if (!currentInstantLogBlocks.isEmpty()) {
+ if (!currentInstantLogBlocks.isEmpty() && !skipProcessingBlocks) {
Review Comment:
yes, without this whatever log instants (`currentInstantLogBlocks`) that
are created during scan() are processed immediately in
`processQueuedBlocksForInstant`.
The v2 scan exposes a interface to skip this processing, but I didn't want
to migrate from v1 to v2 as part of this change, hence added this logic to skip
in v1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
