yihua commented on code in PR #12452:
URL: https://github.com/apache/hudi/pull/12452#discussion_r1926514387
##########
hudi-common/src/main/java/org/apache/hudi/common/model/EventTimeAvroPayload.java:
##########
@@ -41,7 +42,7 @@ public EventTimeAvroPayload(GenericRecord record, Comparable
orderingVal) {
}
public EventTimeAvroPayload(Option<GenericRecord> record) {
- this(record.isPresent() ? record.get() : null, 0); // natural order
+ this(record.isPresent() ? record.get() : null,
COMMIT_TIME_ORDERING_VALUE); // natural order
Review Comment:
Yes, we have special handling on `(integer) 0` even if the ordering field
type is different. So nothing is broken here. This PR keeps the same notion
of `(integer) 0` as the commit-time ordering as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
