yihua commented on code in PR #12452: URL: https://github.com/apache/hudi/pull/12452#discussion_r1926515303
########## hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecord.java: ########## @@ -56,6 +56,7 @@ public abstract class HoodieRecord<T> implements HoodieRecordCompatibilityInterf public static final String FILENAME_METADATA_FIELD = HoodieMetadataField.FILENAME_METADATA_FIELD.getFieldName(); public static final String OPERATION_METADATA_FIELD = HoodieMetadataField.OPERATION_METADATA_FIELD.getFieldName(); public static final String HOODIE_IS_DELETED_FIELD = "_hoodie_is_deleted"; + public static final int COMMIT_TIME_ORDERING_VALUE = 0; Review Comment: I think `COMMIT_TIME_ORDERING_VALUE` is a better name since it indicates commit time ordering. `DEFAULT` or `NON_EXISTANT` might not be obvious, and may lead to confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
