yihua commented on code in PR #12452:
URL: https://github.com/apache/hudi/pull/12452#discussion_r1928095372
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieBaseFileGroupRecordBuffer.java:
##########
@@ -115,9 +114,16 @@ public
HoodieBaseFileGroupRecordBuffer(HoodieReaderContext<T> readerContext,
} else {
this.payloadClass = Option.empty();
}
- this.orderingFieldName =
Option.ofNullable(ConfigUtils.getOrderingField(props)).orElseGet(() ->
hoodieTableMetaClient.getTableConfig().getPreCombineField());
- this.orderingFieldTypeOpt = recordMergeMode ==
RecordMergeMode.COMMIT_TIME_ORDERING ? Option.empty() :
AvroSchemaUtils.findNestedFieldType(readerSchema, this.orderingFieldName);
- this.orderingFieldDefault = orderingFieldTypeOpt.map(type ->
readerContext.castValue(0, type)).orElse(0);
+ this.orderingFieldName = recordMergeMode ==
RecordMergeMode.COMMIT_TIME_ORDERING
Review Comment:
We discussed that if the table version is 6 (Hudi 0.14/0.15 release), from
the `HoodieTableConfig`, it should serve `EVENT_TIME_ORDERING` as the merge
mode if the payload class is `OverwriteWithLatestAvroPayload` with precombine
field in the table config, so that there is no behavior change of reading the
table of version 6 with Hudi 1.x in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
