Davis-Zhang-Onehouse commented on code in PR #12646:
URL: https://github.com/apache/hudi/pull/12646#discussion_r1929476769
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/testutils/HoodieCommonTestHarness.java:
##########
@@ -377,4 +381,20 @@ private static HoodieDataBlock
getDataBlock(HoodieLogBlock.HoodieLogBlockType da
throw new RuntimeException("Unknown data block type " + dataBlockType);
}
}
+
+ protected byte[] getCommitMetadata(String basePath, String partition, String
commitTs, int count, Map<String, String> extraMetadata)
+ throws IOException {
+ HoodieCommitMetadata commit = new HoodieCommitMetadata();
Review Comment:
for the testing I have a separate PR which revised existing test utility
which can easily craft any real timeline without mocking easily. Later when I
resume the work I will throw away these tests and rewriting. The code will be
very straight-forward.
I assume we all agree this is not blocker for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
