Davis-Zhang-Onehouse commented on code in PR #12646:
URL: https://github.com/apache/hudi/pull/12646#discussion_r1929476351
##########
hudi-common/src/main/java/org/apache/hudi/common/table/TableSchemaResolver.java:
##########
@@ -176,32 +185,43 @@ public Option<Schema> getTableAvroSchemaIfPresent(boolean
includeMetadataFields)
return getTableAvroSchemaInternal(includeMetadataFields, Option.empty());
}
- private Option<Schema> getTableAvroSchemaInternal(boolean
includeMetadataFields, Option<HoodieInstant> instantOpt) {
- Option<Schema> schema =
- (instantOpt.isPresent()
- ? getTableSchemaFromCommitMetadata(instantOpt.get(),
includeMetadataFields)
- : getTableSchemaFromLatestCommitMetadata(includeMetadataFields))
- .or(() ->
- metaClient.getTableConfig().getTableCreateSchema()
- .map(tableSchema ->
- includeMetadataFields
- ? HoodieAvroUtils.addMetadataFields(tableSchema,
hasOperationField.get())
- : tableSchema)
- )
- .or(() -> {
- Option<Schema> schemaFromDataFile =
getTableAvroSchemaFromDataFileInternal();
- return includeMetadataFields
- ? schemaFromDataFile
- :
schemaFromDataFile.map(HoodieAvroUtils::removeMetadataFields);
- });
-
- // TODO partition columns have to be appended in all read-paths
- if (metaClient.getTableConfig().shouldDropPartitionColumns() &&
schema.isPresent()) {
+ Option<Schema> getTableAvroSchemaInternal(boolean includeMetadataFields,
Option<HoodieInstant> instantOpt) {
+ return (instantOpt.isPresent()
+ ? getTableSchemaFromCommitMetadata(instantOpt.get(),
includeMetadataFields)
Review Comment:
this is pure code refactor + unit test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
