Davis-Zhang-Onehouse commented on code in PR #12718:
URL: https://github.com/apache/hudi/pull/12718#discussion_r1932709634
##########
hudi-common/src/main/java/org/apache/hudi/common/table/checkpoint/CheckpointUtils.java:
##########
@@ -61,6 +61,20 @@ public static Checkpoint getCheckpoint(HoodieCommitMetadata
commitMetadata) {
throw new HoodieException("Checkpoint is not found in the commit metadata:
" + commitMetadata.getExtraMetadata());
}
+ public static Checkpoint buildCheckpointFromGeneralSource(
+ String sourceClassName, int writeTableVersion, String
checkpointToResume) {
+ return CheckpointUtils.shouldTargetCheckpointV2(writeTableVersion,
sourceClassName)
+ ? new StreamerCheckpointV2(checkpointToResume) : new
StreamerCheckpointV1(checkpointToResume);
+ }
+
+ // Whenever we create checkpoint from streamer config checkpoint override,
we should use this function
+ // to build checkpoints.
+ public static Checkpoint buildCheckpointFromConfigOverride(
Review Comment:
same above. Once we clean up everything is hidden behind the source class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
