nsivabalan commented on code in PR #12718:
URL: https://github.com/apache/hudi/pull/12718#discussion_r1932995760
##########
hudi-common/src/main/java/org/apache/hudi/common/table/checkpoint/CheckpointUtils.java:
##########
@@ -47,8 +47,18 @@ public class CheckpointUtils {
"org.apache.hudi.utilities.sources.S3EventsHoodieIncrSource",
"org.apache.hudi.utilities.sources.GcsEventsHoodieIncrSource",
"org.apache.hudi.utilities.sources.MockS3EventsHoodieIncrSource",
- "org.apache.hudi.utilities.sources.MockGcsEventsHoodieIncrSource"
+ "org.apache.hudi.utilities.sources.MockGcsEventsHoodieIncrSource",
+ "org.apache.hudi.utilities.sources.HoodieIncrSource"
)));
+
+ public static final Set<String> HOODIE_INCREMENTAL_SOURCES;
+
+ static {
+ HashSet<String> tmp = new
HashSet<>(DATASOURCES_NOT_SUPPORTED_WITH_CKPT_V2);
Review Comment:
lets not name it as "tmp"
##########
hudi-common/src/main/java/org/apache/hudi/common/table/checkpoint/CheckpointUtils.java:
##########
@@ -47,8 +47,18 @@ public class CheckpointUtils {
"org.apache.hudi.utilities.sources.S3EventsHoodieIncrSource",
"org.apache.hudi.utilities.sources.GcsEventsHoodieIncrSource",
"org.apache.hudi.utilities.sources.MockS3EventsHoodieIncrSource",
- "org.apache.hudi.utilities.sources.MockGcsEventsHoodieIncrSource"
+ "org.apache.hudi.utilities.sources.MockGcsEventsHoodieIncrSource",
+ "org.apache.hudi.utilities.sources.HoodieIncrSource"
)));
+
+ public static final Set<String> HOODIE_INCREMENTAL_SOURCES;
+
+ static {
+ HashSet<String> tmp = new
HashSet<>(DATASOURCES_NOT_SUPPORTED_WITH_CKPT_V2);
Review Comment:
also lets do
```
public static final Set<String> DATASOURCES_NOT_SUPPORTED_WITH_CKPT_V2 =
Collections.unmodifiableSet(new HashSet<>(Arrays.asList(
"org.apache.hudi.utilities.sources.S3EventsHoodieIncrSource",
"org.apache.hudi.utilities.sources.GcsEventsHoodieIncrSource",
"org.apache.hudi.utilities.sources.MockS3EventsHoodieIncrSource",
"org.apache.hudi.utilities.sources.MockGcsEventsHoodieIncrSource"
)));
```
and
```
public static Set<String> HOODIE_INCR_SOURCES = new
HashSet<>(DATASOURCES_NOT_SUPPORTED_WITH_CKPT_V2);
HOODIE_INCR_SOURCES.add("org.apache.hudi.utilities.sources.HoodieIncrSource");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
