yihua commented on code in PR #12696:
URL: https://github.com/apache/hudi/pull/12696#discussion_r1960772190
##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java:
##########
@@ -91,22 +90,22 @@ public class RequestHandler {
private final ScheduledExecutorService asyncResultService;
public RequestHandler(Javalin app, StorageConfiguration<?> conf,
TimelineService.Config timelineServiceConfig,
- HoodieEngineContext hoodieEngineContext, HoodieStorage
storage,
- FileSystemViewManager viewManager) throws IOException {
+ HoodieEngineContext hoodieEngineContext,
+ FileSystemViewManager viewManager) {
this.timelineServiceConfig = timelineServiceConfig;
this.viewManager = viewManager;
this.app = app;
- this.instantHandler = new TimelineHandler(conf, timelineServiceConfig,
storage, viewManager);
- this.sliceHandler = new FileSliceHandler(conf, timelineServiceConfig,
storage, viewManager);
- this.dataFileHandler = new BaseFileHandler(conf, timelineServiceConfig,
storage, viewManager);
+ this.instantHandler = new TimelineHandler(conf, timelineServiceConfig,
viewManager);
+ this.sliceHandler = new FileSliceHandler(conf, timelineServiceConfig,
viewManager);
+ this.dataFileHandler = new BaseFileHandler(conf, timelineServiceConfig,
viewManager);
Review Comment:
Could you add tests on these changes which require different
`HoodieStorage` instances based on the schema and bucket so that the tests fail
before the change and pass after the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
