yihua commented on code in PR #12696:
URL: https://github.com/apache/hudi/pull/12696#discussion_r1962842252
##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java:
##########
@@ -91,22 +90,22 @@ public class RequestHandler {
private final ScheduledExecutorService asyncResultService;
public RequestHandler(Javalin app, StorageConfiguration<?> conf,
TimelineService.Config timelineServiceConfig,
- HoodieEngineContext hoodieEngineContext, HoodieStorage
storage,
- FileSystemViewManager viewManager) throws IOException {
+ HoodieEngineContext hoodieEngineContext,
+ FileSystemViewManager viewManager) {
this.timelineServiceConfig = timelineServiceConfig;
this.viewManager = viewManager;
this.app = app;
- this.instantHandler = new TimelineHandler(conf, timelineServiceConfig,
storage, viewManager);
- this.sliceHandler = new FileSliceHandler(conf, timelineServiceConfig,
storage, viewManager);
- this.dataFileHandler = new BaseFileHandler(conf, timelineServiceConfig,
storage, viewManager);
+ this.instantHandler = new TimelineHandler(conf, timelineServiceConfig,
viewManager);
+ this.sliceHandler = new FileSliceHandler(conf, timelineServiceConfig,
viewManager);
+ this.dataFileHandler = new BaseFileHandler(conf, timelineServiceConfig,
viewManager);
Review Comment:
Discussed offline, we could provide test-only implementation classes of
`testfs1://` and `testfs2://` and each implementation throws exception for
other FS schemes. Then test requests with `testfs1://` and `testfs2://` to the
same timeline server. Before this PR, the test should fail while after this PR
the test should pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
